Code Review Request: 7157893: Warnings Cleanup in java.util.*

[Stuart Marks]

On 4/16/12 1:18 PM, Kurchi Hazra wrote:
> Sorry, I forgot to insert a link to the webrev :
> http://cr.openjdk.java.net/~khazra/7157893/webrev.02/
>
> On 4/16/2012 12:31 PM, Kurchi Hazra wrote:
>>
>> On 4/13/2012 8:26 PM, Mike Duigou wrote:
>>> Looks good for commit. Just a few notes
>>>
>>> EnumMap.java:
>>>
>>> maskNull seemed to have the unchecked cast well bottlenecked. Why move the
>>> cast outside of unmaskNull() and thus require @SuppressWarnings("unchecked")
>>> in many other places.
>>
>> I agree with this one. I have updated EnumMap.java to remove cast in
>> unmaskNull() and then remove the unrequired casts. (and some changes in 724,
>> 740 and 789 while I was there)

I should point out that I had previously mentioned the casting in unmaskNull 
but that Remi had disagreed [1]. I was content to let Remi's recommendation 
stand but since Mike raised it again, and Kurchi agreed, I guess that Remi has 
been outvoted while I distracted him by discussing generic reification. :-)

Anyway I think this latest webrev is fine.

s'marks

[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-April/009755.html