PING: [PATCH FOR REVIEW] System Zlib Support

[Andrew Hughes]

----- Original Message -----
> On 03/08/2012 16:58, Andrew Hughes wrote:
> 
> : It's what we've had for years, and was added orthogonally to 8 in:
> 
> changeset:   5118:d45bc4307996
> user:        michaelm
> date:        Tue Mar 06 20:34:38 2012 +0000
> summary:     7113349: Initial changeset for Macosx port to jdk
> 
> though that version is broken (at least on GNU/Linux) without the
> change
> to defines.h I posted in my patch earlier this week. Right, that
> change was for Mac and it didn't have the goal to enable it on
> Linux.
> 
> BTW: Looking at your patch then I suspect it will cause problems on
> other platforms as it only sets ZLIB_LIBS in jdk_generic_profile.sh.
> If folks aren't using this script to setup their environment then
> I'm sure there will be a problem on Mac at least. I don't have time
> to spend on it but I suspect Defs-macosx.gmk will need to be updated
> to make it the default as it does now.
> 

I think that's what Sherman just hit.

I thought the documented way to build was using jdk_generic_profile.sh?
I can add a check to Defs-macosx.gmk.

> 
> 
> If IPP is binary compatible, surely setting ZLIB_LIBS/ZLIB_CFLAGS
> would
> be sufficient?  I don't know how different they are. I believe it is
> binary compatible but I think Sherman is thinking a runtime knob
> rather than a build-time option.
> 
> -Alan.
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07