Request for review: 7191777: test/java/lang/ProcessBuilder/Basic.java failing intermittently due to additions for 4244896
Alan Bateman
Alan.Bateman at oracle.com
Thu Aug 16 07:19:47 UTC 2012
On 16/08/2012 03:18, David Holmes wrote:
> Hi Rob,
>
> On 16/08/2012 9:09 AM, Rob McKenna wrote:
>> Hi folks,
>>
>> One of the tests from 4244896 failed once during nightly testing. It
>> isn't known how much of a delay will be necessary in order for it to
>> pass. In any case the tolerance can't really be loosened much more
>> without making the test meaningless so I've decided to remove it.
>>
>> http://cr.openjdk.java.net/~robm/7191777/webrev.01/
>> <http://cr.openjdk.java.net/%7Erobm/7191777/webrev.01/>
>
> Can we not leave the waitFor in place but simply not check how long we
> waited? That way if it really takes "too long" we hit the default test
> timeout.
That seems a good idea as it also exercises waitFor at around the time
that the process is terminating.
-Alan.
More information about the core-libs-dev
mailing list