RFR [7u8] (JAXP): 7191547 : XMLEventFactory.newFactory(String factoryId, ClassLoader loader) does not work as expected

[Joe Wang]

Thanks, Lance!

On 8/17/2012 8:26 AM, Lance Andersen - Oracle wrote:
> Hi Joe,
>
> Looks fine.
>
> Best
> Lance
> On Aug 17, 2012, at 12:07 AM, Joe Wang wrote:
>
>> In the patch for 6756677, we fixed errors in StAX's input and output 
>> factories where factoryId such as 'javax.xml.stream.XMLInputFactory" 
>> was taken as factory class e.g. 
>> com.sun.xml.internal.stream.XMLInputFactoryImpl.  Unfortunately, we 
>> missed XMLEventFactory in that patch.
>>
>> So this is a patch for XMLEventFactory similar to that of 
>> XMLInputFactory and XMLOutputFactory.  The change itself is to search 
>> an implementation class using the provided factory id instead of 
>> trying to create a instance directly.
>>
>> The webrev is here: 
>> http://cr.openjdk.java.net/~joehw/7u8/7191547/webrev/ 
>> <http://cr.openjdk.java.net/%7Ejoehw/7u8/7191547/webrev/>
>>
>> All tests pass except two XMLEventFactory tests that assumed the 
>> factoryId to mean factory class. They will be updated once this patch 
>> is approved.
>>
>> Thanks,
>> Joe
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>