Review Request: 7193339 Prepare system classes be defined by a non-null module loader
Alan Bateman
Alan.Bateman at oracle.com
Thu Aug 23 18:58:25 UTC 2012
On 23/08/2012 18:43, Mandy Chung wrote:
> This change is to bring the jdk modularization changes from jigsaw
> repo [1]
> to jdk8. This allows the jdk modularization changes to be exposed for
> testing as early as possible and minimize the amount of changes carried
> in the jigsaw repo that helps sync up jigsaw with jdk8/jdk9.
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7193339/webrev.00/
>
This looks good to me and it's good to have these changes in jdk8.
One suggestion for ReflectUtil is to add a private static boolean
isAncestor method as I think that would make the checks in
needsPackageAccessCheck easier to read. Also in ClassLoader you could
use just use needsClassLoaderPermissionCheck(from,to).
-Alan.
More information about the core-libs-dev
mailing list