[PATCH FOR REVIEW] 7194032: update tests for upcoming changes for jtreg

[Alan Bateman]

On 25/08/2012 00:48, Jonathan Gibbons wrote:
> Currently, jtreg incorrectly confuses the concept of the /directory/ 
> in which the test's class will be written with the /classpath/ used to 
> locate all of the test's classes, including any library classes. It 
> provides env variable TESTCLASSES and system property test.classes, 
> and tests use these in different contexts to mean both a directory and 
> a classpath.
>
> jtreg will be fixed to separate the two concepts, such that 
> TESTCLASSES/test.classes will continue to mean the /directory/ in 
> which the test's class will the written, and will introduce 
> TESTCLASSPATH/test.class.path for the classpath used to locate all the 
> test's classes.
>
> This change only affects a small number of tests, which use @library 
> and TESTCLASSES. Two RMI tests are affected.
>
> FAILED: java/rmi/activation/Activatable/extLoadedImpl/ext.sh
> FAILED: java/rmi/registry/readTest/readTest.sh
>
> The fix is to update the tests where they are using 
> TESTCLASSES/test.classes as a classpath.
>
> To ease migration onto the new jtreg, it is suggested that the tests 
> check to see if the new variables are defined (i.e. new jtreg) and to 
> fall back on the old variables if they are not defined (i.e. old 
> jtreg). In shell terms, this can be written
>     ${TESTCLASSPATH:-${TESTCLASSES}}
>
> The patch can be seen here:
>     http://cr.openjdk.java.net/~jjg/7194032/webrev.00/
This looks fine to me.

-Alan.