Review Request: 7193406 - Clean-up JDK Build Warnings in java.util, java.io

[David Holmes]

On 25/08/2012 8:05 AM, Omair Majid wrote:
> On 08/23/2012 09:43 PM, Stuart Marks wrote:
>> However, there are several cases where the following occurs:
>>
>>      SUBDIRS_MAKEFLAGS += JAVAC_WARNINGS_FATAL=true
>>
>> and this is **not** overridable on the command line.
>
> But it is! Use:
>
> make SUBDIRS_MAKEFLAGS=""
>
> instead of
>
> SUBDIRS_MAKEFLAGS="" make

I thnk you are missing the point. The above wipes out all of 
SUBDIRS_MAKEFLAGS, but all that is desired is to change the component of 
it that contains JAVAC_WARNINGS_FATAL=true. There is no way to do that 
from the command-line.

David


> See:
> http://www.gnu.org/software/make/manual/html_node/Overriding.html
> http://theory.uwinnipeg.ca/localfiles/infofiles/make/make_66.html
> http://stackoverflow.com/a/2826178
>
> Cheers,
> Omair