Review Request: 7193683: Cleanup Warning in java.sql package

Ulf Zibis Ulf.Zibis at CoSoCo.de
Wed Aug 29 09:28:38 UTC 2012


Looks good!

While you are there maybe correct indentations and tab -> spaces, e.g.:
  531                 } catch(Throwable t) {
  532                 // Do nothing
  533                 }
But here maybe better:
  531                 } catch(Throwable t) {} // Do nothing

-Ulf


Am 29.08.2012 07:29, schrieb Dan Xu:
> I made a simple fix to clean up build warnings in java.sql package. The change can be reviewed at 
> http://cr.openjdk.java.net/~dxu/7193683/webrev.01/. Thanks!
>
> -Dan
>




More information about the core-libs-dev mailing list