RFR: 8003596 CheckLockLocationTest-Windows-fix

Jim Gish jim.gish at oracle.com
Tue Dec 4 16:49:27 UTC 2012


http://cr.openjdk.java.net/~jgish/Bug8003596-CheckLockLocationTest-Windows-fix/ 
<http://cr.openjdk.java.net/%7Ejgish/Bug8003596-CheckLockLocationTest-Windows-fix/>

Better?  :-)

Thanks,
    Jim

On 12/04/2012 06:28 AM, Alan Bateman wrote:
> On 03/12/2012 15:01, Jim Gish wrote:
>> Thanks.  Could you please push the change.
>>
>> Jim
> I assume you also need to remove it from the exclude list (otherwise 
> it will not run)?
>
> Also did you consider using !isWindows() rather than !ON_WINDOWS, I 
> think it would be neater. Better again would be just handle 
> setWritable returning false, then you wouldn't to do anything Windows 
> specific.
>
> -Alan.

-- 
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.gish at oracle.com




More information about the core-libs-dev mailing list