CFR: javax.xml.parsers: Using ServiceLoader to load JAXP parser factories (7169894: JAXP Plugability Layer: using service loader)

[Daniel Fuchs]

Updated the javadoc for newInstance():

<http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.parsers/webrev.02/>

-- daniel

On 12/6/12 11:04 AM, Alan Bateman wrote:
> On 05/12/2012 16:17, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find below a revised version of the changes for
>> the javax.xml.parsers package.
>>
>> It hopefully incorporates all comments I have received so far.
>>
>> <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.parsers/webrev.01/>
>>
>>
>> * better wording/formating for Javadoc changes
>> * using for( : ) syntax in findServiceProvider
>> * improved // comments explaining why the additional layer of
>>   RuntimeException is needed when wrapping ServiceConfigurationError.
>>
>> best regards,
>>
>> -- daniel
> You've addressed all my comments and I think this looks very good.
>
> One other comment. Now that the wording is "Otherwise the default
> implementation, if present, is returned" it raises the question as to
> how what happens if the default implementation is not present. A
> suggestion is to just handle it in the next statement, something like
> "In the case of a SCE or the default provider is not present, then FCE
> will be thrown".
>
> I see Mandy's comment about the bullet item "Platform default
> <code>DocumentBuilderFactory</code> instance". I hadn't noticed this but
> I assume this should just be removed now.
>
> -Alan.