Review request: 8004042 : Arrrghs.java test failed on windows with access error.

[Stuart Marks]

OK, looks pretty good. But....

One little thing is still bothering me. Suppose we get interrupted from the 
sleep() and bail out on that basis. If we got to the point where we're 
sleeping, we must have caught an AccessDeniedException previously. 
Unfortunately this exception is discarded if we were interrupted. This might 
lose valuable diagnostic information. So, what do we do with it? How about adding:

     ie.addSuppressed(cause);

in the catch InterruptedException clause, before throwing the RuntimeException.

(There's another issue which is that if there were previous retries, the ADEs 
from them are thrown away. But maybe we should save that one for another day.)

s'marks

On 12/6/12 9:41 AM, David DeHaven wrote:
>
> New webrev posted:
> http://cr.openjdk.java.net/~ddehaven/8004042/webrev.2/
>
> Summary:
> - Cleaned it up a bit by change to a for loop (eliminating done flag)
> - Throws RuntimeException instead of IOException, handles InterruptedException
> - Bumped retry count to 10
> - Changed @run mode to "main/othervm" as suggested by Kumar
>
> -DrD-
>