CFR: javax.xml.parsers: Using ServiceLoader to load JAXP parser factories (7169894: JAXP Plugability Layer: using service loader)

[Joe Wang]

Hi Daniel,

Looks good!

Joe

On 12/10/2012 9:12 AM, Daniel Fuchs wrote:
> Hi,
>
> After further discussion with Joe & Alan, I changed the call
> to ServiceLoader to simply return the first provider it finds,
> or null.
>
> This is closer to what was present in JDK 7 - and looping is
> not necessary in JDK 8 since the default implementation is
> not returned as a service provider.
>
> So here is a new - and hopefully simpler webrev:
>
> <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.parsers/webrev.04/> 
>
>
> best regards,
>
> -- daniel
>
> On 12/7/12 7:37 PM, Mandy Chung wrote:
>> On 12/7/12 8:32 AM, Alan Bateman wrote:
>>> On 07/12/2012 15:15, Daniel Fuchs wrote:
>>>> Hi Alan,
>>>>
>>>> I have updated the webrev according to your suggestion. I think it 
>>>> makes
>>>> things much clearer.
>>>>
>>>> The new version is there:
>>>>
>>>> <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.parsers/webrev.03/> 
>>>>
>>>>
>>> This looks good to me except that "implementation system default"
>>> should be "system-default implementation".
>>>
>> Looks good to me too with the change to  "system-default 
>> implementation".
>>
>> Mandy
>>
>