Review request: JDK-8004928 TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem.

[Daniel D. Daugherty]

For this item:

 >     test/java/util/logging/LoggingDeadlock4.java
 >         Test case was simplified to avoid AWT class loading. Negative 
test
 >         result was tested on early JDK7 build.

if I remember correctly, the whole point of that test was to
check for a logging deadlock relative to AWT's usage of logging.
If you avoid loading AWT classes, doesn't that make the test
rather useless?

Dan


On 12/12/12 8:41 AM, Alexey Utkin wrote:
> Bug description:
> https://jbs.oracle.com/bugs/browse/JDK-8004928
>
> Here is the suggested fix:
> http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8004928/webrev.01
>
> Summary:
> *test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java*
> *test/java/lang/reflect/Proxy/ClassRestrictions.java*
>         The set of non-public interfaces was changed to avoid AWT 
> dependencies.
>
> *test/java/lang/management/CompilationMXBean/Basic.java*
>         The ballast calls
>             java.awt.Toolkit.getDefaultToolkit();
>             javax.swing.UIManager.getInstalledLookAndFeels();
>         were removed from compiled Java code. Compilation time still 
> positive.
>
> *test/java/lang/reflect/Generics/Probe.java*
>         The dependence from the internal class 
> "javax.swing.JComboBox$AccessibleJComboBox"
>         was excepted from code. It has very small impact to test coverage.
>
> *test/java/util/Collections/EmptyIterator.java*
>         Swing-stored constants were changed to locally-defined.
>
> *test/java/util/logging/LoggingDeadlock4.java*
>         Test case was simplified to avoid AWT class loading. Negative 
> test result was tested on early
>         JDK7 build.
>
> *test/sun/tools/jrunscript/common.sh*
>         Useless mention of XToolkit  was removed from the script.
>
> Regards,
> -uta
>