Review request: JDK-8004928 TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem (ver. 2)

Alexey Utkin alexey.utkin at oracle.com
Thu Dec 13 11:59:50 UTC 2012


On 13.12.2012 15:56, Alan Bateman wrote:
> On 13/12/2012 11:48, Alexey Utkin wrote:
>> Here is new version fix:
>>     
>> http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8004928/webrev.02
> This looks good to me and thanks for the confirmation that 
> LoggingDeadlock4 continues to test what it was meant to test.
>
> Minor comment on ClassRestrictions.java is that you've changed the 
> test to throw Error rather than RuntimeException. Either will cause 
> the test to fail so it doesn't matter of course.
I did it just for code unification between
     test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java
     test/java/lang/reflect/Proxy/ClassRestrictions.java
tests. Yes, that need to be mentioned in summary. Sorry.

-uta




More information about the core-libs-dev mailing list