8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present

Alan Bateman Alan.Bateman at oracle.com
Fri Dec 14 15:13:50 UTC 2012


On 13/12/2012 21:46, Joe Wang wrote:
> :
>
> What I was thinking?!  I had the property dtd in mind that requires 
> the elements all be in lower cases, so therefore I should ignore case 
> and allow it -- any better logic than that? :-)
>
> Fixed now. And also added a couple of test cases.  Elements with wrong 
> case would still have been rejected, but the error messages would be 
> different.
I've put an updated webrev here:

http://cr.openjdk.java.net/~alanb/8004371/webrev.03/

This has the equalsIgnoreCase -> case change to address the issue that 
Paul spotted.

I've also liberated two tests for this area that we had elsewhere. They 
are moved into un-changed for now and will exercise the new code when 
run the smallest profile.

Joe - if you can get your additional tests into a form that can be 
included in the jdk repository then we can include them in this push, 
alternatively you can do it as a follow-up change-set that expands the 
test coverage.

-Alan.





More information about the core-libs-dev mailing list