RFR: (jaxp) 8003260 : some fields should be package protected

[Lance Andersen - Oracle]

+1
On Dec 14, 2012, at 3:43 PM, Joe Wang wrote:

> Thanks.  I added a comment.  Here's the webrev again:
> http://cr.openjdk.java.net/~joehw/7u12/8003260/webrev/
> 
> Best
> Joe
> 
> On 12/14/2012 11:52 AM, Lance Andersen - Oracle wrote:
>> 
>> Thanks Joe.  maybe a quick comment would help in the code could be useful
>> 
>> Best
>> Lance
>> On Dec 14, 2012, at 2:49 PM, Joe Wang wrote:
>> 
>>> 
>>> 
>>> On 12/14/2012 10:36 AM, Lance Andersen - Oracle wrote:
>>>> 
>>>> Hi Joe,
>>>> 
>>>> Shouldn't this also be private:
>>>> 
>>>>  static final char [] xmlDecl = {'<','?','x','m','l'};
>>> 
>>> A subclass in the same package, XMLDocumentScannerImpl, referred to it. That's why I made it package private.
>>> 
>>> Joe
>>>> otherwise it is fine
>>>> Best
>>>> Lance
>>>> On Dec 14, 2012, at 1:33 PM, Joe Wang wrote:
>>>> 
>>>>> Hi,
>>>>> 
>>>>> This is one of the three [findbug] issues. I've checked with Drew. None of them are vulnerabilities. Nonetheless, the fields should have been private or package private.
>>>>> 
>>>>> webrev:
>>>>> http://cr.openjdk.java.net/~joehw/7u12/8003260/webrev/
>>>>> 
>>>>> Test:
>>>>> No new test. Existing regression tests passed.
>>>>> 
>>>>> Thanks,
>>>>> Joe
>>>> 
>>>> 
>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering 
>>>> 1 Network Drive 
>>>> Burlington, MA 01803
>>>> Lance.Andersen at oracle.com
>>>> 
>> 
>> 
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com
>> 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com