RFR: javax.xml.stream: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

Mandy Chung mandy.chung at oracle.com
Tue Dec 18 19:04:15 UTC 2012


On 12/18/12 1:09 AM, Paul Sandoz wrote:
> On Dec 18, 2012, at 7:02 AM, Mandy Chung<mandy.chung at oracle.com>  wrote:
>
>> Hi Daniel,
>>
>> There are currently several different FactoryFinder class in the JAXP implementation and there might be slight difference in each of them.  Do you know if it has been looked into whether it's feasible to merge them into a single utility class?  I suspect someone might have brought this up in the past.
>>
> You suspect right :-)
>
> Those FactoryFinder classes are package private, probably a artefact of JAXP having multiple distribution channels, and there were subtle differences between them but perhaps less so now?
>
> IMHO such unification could be considered as a later fix as i think getting the SL and CL functionality correct is a higher priority.

Agree and such unification can be done separately.

> http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.stream/webrev.01/

Daniel - I reviewed the change and also the latest webrev for 
parser/stream. They look good to me.

Thanks
Mandy



More information about the core-libs-dev mailing list