JDK 8 code review request for 8005042 Add Method.isDefault to core reflection
Mandy Chung
mandy.chung at oracle.com
Tue Dec 18 21:21:03 UTC 2012
On 12/18/12 12:43 PM, Joe Darcy wrote:
> Hello,
>
> Please review these changes to add core reflection support to
> recognize default methods:
>
> 8005042 Add Method.isDefault to core reflection
> http://cr.openjdk.java.net/~darcy/8005042.0/
>
Looks good to me.
For the test:
56 System.err.printf("ERROR: On %s expected isDefualt of ''%s''; got ''%s''.\n",
57 method.toString(), expected, actual);
A typo 'isDefualt' -> 'isDefault'. This uses two single-quote
characters to wrap the expected and actual value - is it intentional? I
was wondering that you meant to use one singe-quote character.
Mandy
More information about the core-libs-dev
mailing list