JDK 8 review request for 8005097 Tie isSynthetic javadoc to the JLS

Joe Darcy joe.darcy at oracle.com
Wed Dec 19 19:19:20 UTC 2012


Hello,

It has come to my attention recently that the various isSynthetic 
methods in core reflection cite the Java Language Specification, but do 
not reference a particular section.  To remedy this, I've prepared a 
small patch to add "@jls" tags which cite the section in question:

     http://cr.openjdk.java.net/~darcy/8005097.0/

Inline patch file below.

Thanks,

-Joe

--- old/src/share/classes/java/lang/Class.java    2012-12-19 
11:11:40.000000000 -0800
+++ new/src/share/classes/java/lang/Class.java    2012-12-19 
11:11:39.000000000 -0800
@@ -506,6 +506,7 @@
       * returns {@code false} otherwise.
       * @return {@code true} if and only if this class is a synthetic 
class as
       *         defined by the Java Language Specification.
+     * @jls 13.1 The Form of a Binary
       * @since 1.5
       */
      public boolean isSynthetic() {
--- old/src/share/classes/java/lang/reflect/Constructor.java 2012-12-19 
11:11:40.000000000 -0800
+++ new/src/share/classes/java/lang/reflect/Constructor.java 2012-12-19 
11:11:40.000000000 -0800
@@ -411,6 +411,7 @@

      /**
       * {@inheritDoc}
+     * @jls 13.1 The Form of a Binary
       * @since 1.5
       */
      @Override
--- old/src/share/classes/java/lang/reflect/Executable.java 2012-12-19 
11:11:40.000000000 -0800
+++ new/src/share/classes/java/lang/reflect/Executable.java 2012-12-19 
11:11:40.000000000 -0800
@@ -324,6 +324,7 @@
       * @return true if and only if this executable is a synthetic
       * construct as defined by
       * <cite>The Java™ Language Specification</cite>.
+     * @jls 13.1 The Form of a Binary
       */
      public boolean isSynthetic() {
          return Modifier.isSynthetic(getModifiers());
--- old/src/share/classes/java/lang/reflect/Member.java 2012-12-19 
11:11:41.000000000 -0800
+++ new/src/share/classes/java/lang/reflect/Member.java 2012-12-19 
11:11:41.000000000 -0800
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 1996, 2006, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1996, 2012, Oracle and/or its affiliates. All rights 
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -87,6 +87,7 @@
       *
       * @return true if and only if this member was introduced by
       * the compiler.
+     * @jls 13.1 The Form of a Binary
       * @since 1.5
       */
      public boolean isSynthetic();
--- old/src/share/classes/java/lang/reflect/Method.java 2012-12-19 
11:11:41.000000000 -0800
+++ new/src/share/classes/java/lang/reflect/Method.java 2012-12-19 
11:11:41.000000000 -0800
@@ -500,6 +500,7 @@

      /**
       * {@inheritDoc}
+     * @jls 13.1 The Form of a Binary
       * @since 1.5
       */
      @Override



More information about the core-libs-dev mailing list