Please review: 7131266: JDK 7 pack200 + unpack200 fails on jaxb-xjc.jar

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Fri Feb 10 18:37:30 UTC 2012


Hello,

Please review fix for : 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131266

The gist of the problem being addressed, the specimen jar contains
two versions of class file implementations with the same package names,
this tends to confuse the pack200 mechanism causing it to fire asserts.

This fixes two issues:
1. Made the equals method more stringent to ensure the CP tag is compared
     correctly [ this can happen for MemberEntry which can have Fields, 
Methods and
     InterfaceMethods,]  and some minor cleanups.

2. A class file not playing nice, ie. package name does not reflect the 
actual
     directory structure they are in,  will not be considered for 
compression, instead
     these will be passed through "as-is".

http://cr.openjdk.java.net/~ksrini/7131266/webrev.0/

Thanks

Kumar





More information about the core-libs-dev mailing list