Reviewer needed: (JDK7) fixed three typos in a class ScriptEngineManager

Pavel Tisnovsky ptisnovs at redhat.com
Tue Feb 28 14:59:08 UTC 2012


Alan Bateman wrote:
> On 28/02/2012 13:36, Pavel Tisnovsky wrote:
>> Hi,
>>
>> I'd like to fix three typos in ScriptEngineManager class's JavaDoc.
>> This class contains method getEngineFactories() which returns
>> list of factories, not an array of factories.
>>
>> Here is a webrew created against OpenJDK7:
>>
>> http://cr.openjdk.java.net/~ptisnovs/ScriptEngineManager/
>>
>> Can anybody review this change please?
>>
>> PS: similar typos exist in OpenJDK6 too.
>>
>> Thank you in advance,
>> Pavel Tisnovsky
> Looks okay to me. One of the rules [1] for changes going into jdk7u is
> that the change be in jdk8 first. The jdk8/tl/jdk repository would be
> the best place to push this.

Hi Alan and Rémi,

thank you for review.

According to rules I've prepared webrew for JDK8
http://cr.openjdk.java.net/~ptisnovs/ScriptEngineManager_jdk8/

(changed texts are the same, but line numbers differ)

Pavel

PS: I have not a chance to push anything to JDK8 yet.
Do I have the rights to push anything to JDK8 tl inherited from JDK6 or 7?

> 
> -Alan
> 
> [1] http://openjdk.java.net/projects/jdk7u/groundrules.html




More information about the core-libs-dev mailing list