Review needed for 7132879 to address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl

[Lance Andersen - Oracle]

Hi Remi,

Thanks for the feedback,   I made the suggested changes http://cr.openjdk.java.net/~lancea/7133815/webrev.01/ and re-ran the rowset tck .

Best
Lance
On Jan 26, 2012, at 5:21 PM, Rémi Forax wrote:

> On 01/26/2012 10:46 PM, Lance Andersen - Oracle wrote:
>> Hi,
>> 
>> Looking for a reviewer for http://cr.openjdk.java.net/~lancea/7133815/webrev.00/
>> 
>>  this is a small change to address 2 findbug errors.  The findbug issues being addressed:
>> 
>> May expose internal representation by returning reference to mutable object
>> 
>> and
>> 
>> Load of known null value
>> 
>> 
>> For  CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl
> 
> Hi Lance,
> I think it's better to use array.clone() or
> Arrays.copyOf(array, array.length) which is a little faster.
> 
> so the code of CachedRowSetImpl should be:
> 
> int[]keyCols  = this.keyCols;
> return (keyCols == null)? null: Arrays.copyOf(keyCols, keyCols.length);
> 
> otherwise the code of SQLOutputImpl is ok for me.
> 
> cheers,
> Rémi
> 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com