Please review: 7127906: (launcher) convert the launcher regression tests to java

Joe Darcy joe.darcy at oracle.com
Fri Jan 27 18:30:29 UTC 2012


Hi Kumar,

Looks fine; good to see the shell code go away!

-Joe

On 01/27/2012 10:03 AM, Kumar Srinivasan wrote:
> Hi Joe, Naoto, Sherman,
>
> Here are the highlights of these changes:
>
> 1. The TestHelper.java is now extensible, this simplifies the usage of 
> static variables
>      and methods, added a couple of convenience methods and some minor 
> refactoring.
>
> 2. Eliminated some shell tests,  (few more remaining, saved for a 
> future project).
>     a. UnicodeTest.sh, UnicodeCleanup.java merged into UnicodeTest.java
>     b. i18nTest.sh, deleteI18n.sh, CreatePlatformFile.java merged into 
> I18NTest.java
>     c. ChangeDataModel.sh converted to ChangeDataModel.java
>     d. unresolvedExceptions.sh converted and merged into 
> UnresolvedExceptions.java
>
> 3.  Arrrghs.java when testing on Solaris with ja_JP.UTF-8 locale, some 
> of the tests fail
>      as the launcher messages in java are localized,  therefore these 
> tests are skipped,
>      under such conditions.
>
> Tests: Windows English/Japanese, Solaris  C/ja_JP.UTF-8 + usual jprt 
> systems (undergoing).
>
> webrev: http://cr.openjdk.java.net/~ksrini/7127906/webrev.0/
>
> Thanks
> Kumar
>
>




More information about the core-libs-dev mailing list