Fwd: Review request CR 7171918 XmlReaderContentHandler.endElement does not handle a Delete Tag properly

[Lance Andersen - Oracle]

Still looking for a reviewer on this.

All SQE, unit tests, JCK and TCK tests pass. 


Best
Lance

Begin forwarded message:

> From: Lance Andersen - Oracle <Lance.Andersen at oracle.com>
> Date: May 25, 2012 3:56:41 PM EDT
> To: core-libs-dev core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: Review request CR 7171918 XmlReaderContentHandler.endElement does not handle a Delete Tag properly
> 
> Attached is the fix for 7171918.   If a WebRowSet is written to disk that contains a row marked for deletion and then read back into a WebRowSet, it was not marked again as a deleted row.
> 
> Here is the fix to endElement() to address this.
> 
>  hg diff XmlReaderContentHandler.java 
> diff -r 4580652d9828 src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java
> --- a/src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java	Fri May 04 16:00:47 2012 -0400
> +++ b/src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java	Fri May 25 15:52:21 2012 -0400
> @@ -764,6 +764,7 @@
>                      rs.next();
>                      rs.setOriginalRow();
>                      applyUpdates();
> +                    rs.deleteRow();
>                  } catch (SQLException ex) {
>                      throw new SAXException(MessageFormat.format(resBundle.handleGetObject("xmlrch.errdel").toString() , ex.getMessage()));
> 
> 
> Best,
> Lance
> 
> 
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> Lance.Andersen at oracle.com
> 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com