Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Rémi Forax forax at univ-mlv.fr
Wed Jun 20 14:08:28 UTC 2012


On 06/20/2012 01:51 PM, Martijn Verburg wrote:
> Hi all,
>
> Apologies, I didn't check that attachments were stripped.  The patches
> can be found at:
>
> https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_text.patch
> https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_util.patch
>
> Cheers,
> Martijn

Hi Martijn,
the two patches looks good.

A minor nit, why is there a space between the '(' and the readUByte() in 
readUShort.

Rémi

>
> On 20 June 2012 09:50, Martijn Verburg <martijnverburg at gmail.com> wrote:
>> Hi Stuart,
>>
>> As requested - attached are 2 patch files, one covering util, the other text.
>>
>> I'm aware some fixes did go in recently, so if these patches are out
>> of date and need re-spinning, then please let me know.
>>
>> Cheers,
>> Martijn (on behalf of Adopt OpenJDK)





More information about the core-libs-dev mailing list