Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

[Kurchi Subhra Hazra]

Hi,

   I was just going through the patches, there are some more fallthrough 
cases in
src/share/classes/java/util/regex/Pattern.java.(for example in line 2247).
Are these not generating warnings?

- Kurchi

On 6/20/12 7:30 AM, Martijn Verburg wrote:

>>> Hi all,
>>>
>>> Apologies, I didn't check that attachments were stripped.  The patches
>>> can be found at:
>>>
>>>
>>> https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_text.patch
>>>
>>> https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_util.patch
>>>
>>> Cheers,
>>> Martijn
>>
>> Hi Martijn,
>> the two patches looks good.
>>
>> A minor nit, why is there a space between the '(' and the readUByte() in
>> readUShort.
> Thanks for the quick review! No reason on the whitespace, I've fixed that now.
>
> Quick question.  Is there a checkstyle or jcheck that we should be
> applying to any corelib patches going forwards?
>
> Cheers,
> Martijn