Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

Ulf Zibis Ulf.Zibis at gmx.de
Fri Mar 9 10:49:18 UTC 2012


Am 09.03.2012 10:53, schrieb David Holmes:
> Hi Sean,
>
> That seems to implement the required semantics.
>
> Minor style nit: }else{ -> } else {
There are some more in lines 183, 184, 188.

>
> Not sure about the testcase ... Can size() not remove some elements directly but return the 
> original size?
Good idea.
Additionally there should be another TConcurrentHashMap for the opposite testcase: More elements 
than expected.

Please add comment
     // more elements than expected
before line 199

-Ulf




More information about the core-libs-dev mailing list