Code Review Request: 7152007: Fix warnings in sun/rmi/rmic
Stuart Marks
stuart.marks at oracle.com
Fri Mar 16 01:05:56 UTC 2012
Changes look good. I'm told that the build indeed doesn't break, so that's good
too!
s'marks
On 3/15/12 3:02 AM, Chris Hegarty wrote:
> The changes look fine, assuming it now passes a non-SKIP_BOOT_CYCLE build ;-)
>
> -Chris.
>
> On 15/03/12 01:31, Kurchi Hazra wrote:
>> Hi,
>>
>> The warning fixes in sun/rmi/rmic originally pushed as a part of CR
>> 7146763, were undone by 7151348
>> due to build breakage when SKIP_BOOT_CYCLE is set to false.
>> This CR attempts to incorporate these warning fixes into jdk8. Most of
>> the changes have already been code-reviewed [1],
>> but one line is changed in accordance to Stuart Mark's suggestion[2], so
>> that the build doesn't break.
>>
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7152007
>> Webrev: http://cr.openjdk.java.net/~khazra/7152007/webrev.00/
>>
>>
>> Thanks,
>> Kurchi
>>
>> [1]
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-February/009315.html
>>
>> [2]
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-March/009481.html
More information about the core-libs-dev
mailing list