RFR: 7165102 Only run assertion on Integer autoboxing cache size once

Rémi Forax forax at univ-mlv.fr
Tue May 1 11:28:35 UTC 2012


Here is the new webrev with the assert move after line 777 as Joe ask.
http://cr.openjdk.java.net/~forax/integer_valueof2/

Alan or Joe, it let you commit it if there is no new issue.

Rémi


On 04/30/2012 06:09 PM, Alan Bateman wrote:
> On 27/04/2012 23:38, Rémi Forax wrote:
>> :
>> I have moved the assert into the static block of IntegerCache.
>> For Alan, because IntegerCache is loaded when Integer.valueOf() is 
>> called the first time
>> the assert code is checked around the same time so after the system 
>> init but only once.
>>
>> webrev is here:
>>   http://cr.openjdk.java.net/~forax/integer_valueof/
>> and I need a bug for it :)
> Looks fine me as the initialization is now different compared to when 
> this property was introduced (when introduced the IntegerCache was 
> initialized via System.initializeSystemClass). 


On 04/28/2012 01:32 AM, Joseph Darcy wrote:

>
> Here is your bug:
>
>     7165102 Only run assertion on Integer autoboxing cache size once
>
> However, I'd prefer the assert appear right after the
>
>      777             high = h;
>
> assignment.
>
> Cheers,
>
> -Joe



More information about the core-libs-dev mailing list