[PATCH FOR REVIEW] ResourceManager.getApplicationResources() does not close InputStreams

[Andrew Hughes]

----- Original Message -----
> Is there a reason the patch was not created originally leveraging
> try-with-resources as it seems like the perfect candidate from the
> webrev?
> 
> I can create a bug for it, but I think I would prefer to see the
> patch take advantage of try-with-resoruces
> 

As you can see on the IcedTea bug, I've asked the same question.
I'd have preferred it to use try-with-resources myself (easier to
follow for one thing), but given the patch is as it is, I'm now
wary about changing it and negating the existing testing that's
already been done.

> Best
> Lance
> On Nov 7, 2012, at 3:30 PM, Andrew Hughes wrote:
> 
> > IcedTea bug:
> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
> > 
> > com.sun.naming.internal.ResourceManager.getApplicationResources()
> > does not close the input streams it gets from
> > helper.getResources() and helper.getJavaHomeLibStream().  This
> > patch:
> > 
> > http://cr.openjdk.java.net/~andrew/pr1197/webrev.01/
> > 
> > adds finally blocks to close these streams.  As noted in the
> > original bug report, this has been tested on a J2EE
> > server (JBoss) without issue.
> > 
> > I realise that there's a possibility that try-with-resources could
> > be used here, but the patch as posted
> > is the one that was tested and I don't want to negate that testing
> > by changing it.
> > 
> > Ok for tl?  If so, can I have a bug ID for this?
> > 
> > Thanks,
> > --
> > Andrew :)
> > 
> > Free Java Software Engineer
> > Red Hat, Inc. (http://www.redhat.com)
> > 
> > PGP Key: 248BDC07 (https://keys.indymedia.org/)
> > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
> > 
> 
> 
> 
> [image/gif:oracle_sig_logo.gif]
> 
> 
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07