Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

[Sean Chou]

Hello Chris, Alan, and Xueming,

I added the testcase, please take a look.

webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.01/




On Wed, Nov 7, 2012 at 6:16 PM, Chris Hegarty <chris.hegarty at oracle.com>wrote:

> The change looks fine to me.
>
> I wonder if it is worth creating an automatic regression test to verify
> this change ( so an future regression in behavior gets caught early ). You
> could call sun.tools.jar.Main directly passing suitable streams to check
> the output.
>
> -Chris.
>
>
> On 07/11/2012 08:31, Sean Chou wrote:
>
>> Hello,
>>
>> This is the suggested fix described in sun bug 7201156 page. Please take a
>> look.
>>
>> sunbug: http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7201156<http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7201156>
>> webrev: http://cr.openjdk.java.net/~**zhouyx/7201156/webrev.00/<http://cr.openjdk.java.net/~zhouyx/7201156/webrev.00/>
>>
>>


-- 
Best Regards,
Sean Chou