Review Request: 8001533: Java launcher must launch JavaFX applications

[Mandy Chung]

On 11/16/12 9:38 AM, David DeHaven wrote:
>>> I cleaned it up quite a bit, I think it looks a lot better now:
>>> http://cr.openjdk.java.net/~ddehaven/8001533/webrev.1/
>>>
>>> The comments still need some attention, I'll get that first thing on the morrow.
>>>
>>> -DrD-
>>>
>> I haven't done a detailed code review but I'm wondering about preferring JavaFX-Application-Class over Main-Class. I realize there may be some history here, perhaps with the javafxpackager tool, but I'm just concerned that the JAR File specification specifies the Main-Class attribute, now it will be usurped and ignored if this custom attribute is present.
> JavaFX-Application-Class is for backwards compatibility with existing applications, my understanding is it's being deprecated. Moving forward JavaFX applications will only use Main-Class. Kevin can correct me if I'm wrong :)

I have talked with Kevin to understand the backward compatibility 
better.  For an existing JavaFX application, the JAR file manifest 
always has both the Main-Class and JavaFX-Application-Class attributes; 
in this case, it will ignore the Main-Class attribute and launch with 
com.sun.javafx.application.LauncherImpl.  However, during our 
conversation, we raise other questions that don't have a clear answer 
yet. The main ones are whether the new javafxpackager would continue to 
add the Main-Class attribute and what it will be and whether continue to 
use the JavaFX-Application-Class attribute; if the class specified in 
the JavaFX-Application-Class attribute has the main method, what the 
Main-Class attribute should contain?

> Am I wrong in thinking there should be no impact on profile support if it's being deprecated?

If Main-Class is always present with JavaFX-Application-Class, it may be 
no impact; but this seems to be unclear at this moment.  Kevin can chime 
in here and looks like this requires more investigation before we 
continue the code review.

Mandy