Request for Review (#4) : CR#8001634 : Initial set of lambda functional interfaces
Mike Duigou
mike.duigou at oracle.com
Tue Nov 20 04:55:33 UTC 2012
I have posted another revision at
http://cr.openjdk.java.net/~mduigou/8001634/5/webrev/
This version contains some method remaining in the {I|L|D}UnaryOperation and {I|L|D}BinaryOperator and a few Javadoc fixes.
The package javadoc ie. package-info.java, is known to be a weak point right now. We're still debating what must be said here and what would be better said attached to the APIs which consume these functional interfaces.
We don't anticipate many (any?) further changes to the naming before commit at this point.
Mike
On Nov 13 2012, at 17:19 , Mike Duigou wrote:
> Hello all;
>
> I apologize for the quick turnaround from the second review request [1] but I've updated the webrev again:
>
> http://cr.openjdk.java.net/~mduigou/8001634/4/webrev/
>
> Blame a busy Paul Sandoz who his making significant progress on the primitive specializations implementation. ;-)
>
> This update includes:
>
> - Block.apply renamed to Block.accept
> - {Int|Long|Double}Block specializations added.
> - Commented out "extends Combiner<T,T,T>" in BinaryOperator was removed for now since Combiner is out of scope for this review.
> - The {Int|Long|Double} specializations of BinaryOperator and UnaryOperator now show commented out extends of the generic version along with commented out default methods. This change will not be part of the commit but is meant to show where the implementation will be going.
> - The {Int|Long|Double} specializations of Supplier now extend generic Supplier, have getAs{Int|Long|Double} as their abstract method and provide a commented out default get() method to satisfy the need for a get implementation.
> - The {Int|Long|Double} specializations of Function now extend generic Function, have applyAs{Int|Long|Double} as their abstract method and provide a commented out default apply() method to satisfy the need for an apply implementation.
>
> Mike
>
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012225.html
More information about the core-libs-dev
mailing list