Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

[Alexey Utkin]

The sub-task JDK-8003898 (X11 toolkit can be chosen as the default 
toolkit) was resolved.
New version that takes it into account (changes in TraceJFrame.java):
     http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.03/

On 22.11.2012 13:57, Alan Bateman wrote:
> On 22/11/2012 07:38, Alexey Utkin wrote:
>> Bug description:
>> https://jbs.oracle.com/bugs/browse/JDK-7162111
>>
>> Here is the suggested fix that contains the changes in 
>> JFrameCreateTime.java:
>> http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.02
> The changes to test/java/io/Serializable/resolveClass/* looks fine for me.
>
> On JFrameCreateTime.java then I wonder if the headless check should be 
> in TraceJFrame instead. I suspect this because JFrameCreateTime is the 
> "target app" that is traced. Either way, I'm curious why Throwable is 
> caught I looked at GraphicsEnvironment.getLocalGraphicsEnvironment() 
> and isHeadlessInstance() and neither is specified to throw anything, 
> I'm just curious what we are catching and recovering from, an Error 
> perhaps?
>
Done.
> -Alan.