Review Request: 8004201: add reducers to primitive type wrappers

Vitaly Davidovich vitalyd at gmail.com
Fri Nov 30 19:22:35 UTC 2012


Yup, exactly.  I specifically called out the int version as the one to at
least change over to Math since I know that's intrinsified.

Thanks Kris

Sent from my phone
On Nov 30, 2012 2:19 PM, "Krystal Mo" <krystal.mo at oracle.com> wrote:

> Hi Vitaly,
>
> Right now HotSpot only declares and implements the (int,int)->int version
> of Math.min/max as intrinsics.
> Nevertheless, it wouldn't hurt to use the Math methods, in hope that
> they'll get more love in the future :-)
>
> - Kris
>
> On 12/01/2012 02:59 AM, Vitaly Davidovich wrote:
>
>> Hi Akhil,
>>
>> At least for Integer.min/max you may want to use Math.min/max - these are
>> jit intrinsics.  I'd probably use the Math methods for all matching types
>> (int, long, float, double) to cover the bases.
>>
>> Thanks
>>
>> Sent from my phone
>> On Nov 30, 2012 1:45 PM, "Akhil Arora" <akhil.arora at oracle.com> wrote:
>>
>>  Hi
>>>
>>> Requesting review for some basic functionality related to lambdas -
>>>
>>> Add min, max, sum methods to the primitive wrapper classes - Byte, Short,
>>> Integer, Long, Float, Double and Character so as to be able to use them
>>> as
>>> reducers in lambda expressions. Add and, or, xor methods to Boolean.
>>>
>>> http://cr.openjdk.java.net/~****akhil/8004201.0/webrev/<http://cr.openjdk.java.net/~**akhil/8004201.0/webrev/>
>>> <http:/**/cr.openjdk.java.net/~akhil/**8004201.0/webrev/<http://cr.openjdk.java.net/~akhil/8004201.0/webrev/>
>>> >
>>> http://bugs.sun.com/****bugdatabase/view_bug.do?bug_****id=8004201<http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=8004201>
>>> <http://bugs.sun.**com/bugdatabase/view_bug.do?**bug_id=8004201<http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004201>
>>> >
>>>
>>> Thanks
>>>
>>>
>



More information about the core-libs-dev mailing list