Review Request: 7186817 - Remove Windows 95/98/ME Support

Alan Bateman Alan.Bateman at oracle.com
Wed Oct 10 10:58:26 UTC 2012


On 09/10/2012 21:02, Dan Xu wrote:
> :
>
> There are no code changes when moving them from Win32FileSystem to 
> WinNTFileSystem.

Thanks for confirming, that makes it a lot easier to review.

I've looked through the changes and it looks that you've done a very 
thorough job, thank you! The only thing I notice is that a couple of the 
methods that are moved don't need protected access anymore, examples are 
rename0, delete0, getDriveDirectory, canonicalizeWithPrefix and probably 
a few others.

I see Ulf's suggestion to change the hashCode implementation while you 
are there but I agree that this should be looked at separately as the 
focus with this patch is removing code that isn't used anymore.

-Alan






More information about the core-libs-dev mailing list