RFR: 8000817: Reinstate accidentally removed sleep() from ProcessBuilder/Basic.java

[Alan Bateman]

On 12/10/2012 17:17, Martin Buchholz wrote:
> On Fri, Oct 12, 2012 at 7:32 AM, Rob McKenna<rob.mckenna at oracle.com>  wrote:
>
>> Hi folks,
>>
>> Managed to remove the Thread.sleep(10) from the test when fixing 7152183.
>> Sorry about that.
>>
>>
> I thought you had done that intentionally, and so "if it passes, then OK".
>
> The way the code's been written, it should now be robustly race-free on
> Solaris.  Do you actually see racy failures on other OSes?
>
Yes, here's an example on Linux with a build of jdk8/tl that has Rob's 
last change:

----------messages:(3/117)----------
command: main Basic
reason: User specified action: run main/othervm/timeout=300 Basic
elapsed time (seconds): 8.869
----------System.out:(20/750)*----------
This appears to be a Unix system.
Testing ASCII environment values
Testing Latin1 environment values
Testing Unicode environment values
Testing directory .
Testing directory ..
Testing directory /
Testing directory /bin
cmdp
cmdp 0: /export/home/aurora/sandbox/jdk/jre/bin/java
cmdp 1: -classpath
cmdp 2: /export/home/aurora/sandbox/jtreg/lib/javatest.jar:/export/home/aurora/sandbox/jtreg/lib/jtreg.jar:/export/home/aurora/sandbox/gresults/testoutput/jdk_lang/JTwork/classes/java/lang/ProcessBuilder:/export/home/aurora/sandbox/testbase/test/java/lang/ProcessBuilder:/export/home/aurora/sandbox/jdk/lib/tools.jar
cmdp 3: Basic$JavaChild
cmdp 4: System.getenv()
envp
envp 0: LC_ALL=C\u0000\u0000
envp 1: FO\u0000=B\u0000R

Passed = 9018, failed = 1

----------System.err:(18/967)----------
java.io.IOException: Stream closed
	at java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:162)
	at java.io.BufferedInputStream.fill(BufferedInputStream.java:206)
	at java.io.BufferedInputStream.read(BufferedInputStream.java:254)
	at Basic$64.run(Basic.java:1954)
java.lang.AssertionError: Some tests failed
	at Basic.main(Basic.java:2418)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:474)
	at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:94)
	at java.lang.Thread.run(Thread.java:722)

JavaTest Message: Test threw exception: java.lang.AssertionError: Some tests failed
JavaTest Message: shutting down test

STATUS:Failed.`main' threw exception: java.lang.AssertionError: Some tests failed
result: Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed


test result: Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed