Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods

[Roger Riggs]

Thanks for pointing out that omission.
I will fix the spec and the tests to note the special case as
described for the division operator in the JLS.

The other result returning MAX_VALUE from floorDiv(Integer.MIN_VALUE, -1)
does not seem any more beneficial.

Thanks, Roger


On 10/10/2012 12:12 PM, Eamonn McManus wrote:
> One edge case: the spec for floorDiv implies that
> floorDiv(Integer.MIN_VALUE, -1) should be Integer.MAX_VALUE but I
> believe the code produces Integer.MIN_VALUE. EIther the spec or the
> code should be fixed.
>
> Éamonn
>
>
> 2012/10/10 Roger Riggs <Roger.Riggs at oracle.com>:
>> A reviewer is needed for:
>>
>> 6282196 There should be Math.mod(number, modulo) methods
>>
>> The webrev is: http://cr.openjdk.java.net/~rriggs/6282196.4/
>>
>> Thanks, Roger