Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods

[Joe Darcy]

Looks fine Roger; thanks,

-Joe

On 10/13/2012 9:21 AM, Roger Riggs wrote:
> Thanks for the comments and suggestions from Eamonn, Joe, and Bruce.
> The updates add the suggested text and note the special case for 
> floorDiv(MIN_VALUE/-1).
>
> Updated webrev:
>
>     http://cr.openjdk.java.net/~rriggs/6282196.5/
>
> Roger
>
>
> On 10/11/2012 08:40 PM, Joseph Darcy wrote:
>> Hi Roger,
>>
>> The changes look fine.  However, I suggest adding an explanatory note 
>> along the lines of "Normal integer division operates under the round 
>> to zero rounding mode (truncation).  This operation instead acts 
>> under the round to negative infinity (floor) rounding mode. The floor 
>> rounding mode gives different results than truncation when the exact 
>> result is negative."
>>
>> Thanks,
>>
>> -Joe
>>
>> On 10/10/2012 7:22 AM, Roger Riggs wrote:
>>> A reviewer is needed for:
>>>
>>> 6282196 There should be Math.mod(number, modulo) methods
>>>
>>> The webrev is: http://cr.openjdk.java.net/~rriggs/6282196.4/
>>>
>>> Thanks, Roger
>>
>