Request for review : 7088913 :
Joe Darcy
joe.darcy at oracle.com
Thu Oct 25 05:14:02 UTC 2012
Hi Mike,
The code looks fine with one quibble in the test; the bugs should be
listed on the same line. Instead of
* @bug 4245470
+ * @bug 7088913
use
* @bug 4245470 7088913
Thanks,
-Joe
On 10/24/2012 9:07 PM, Mike Duigou wrote:
> A long, long time ago (2011) there was a review request[1] for
>
> CR#7088913 : Add compatible static hashCode(primitive) to primitive wrapper classes
>
> The change was approved by the three cc:ed reviewers. At that time the webrev was co-mingled with another changeset that had more controversial changes. Neither changeset was committed and 7088913 got ignored and eventually forgotten. Until now.
>
> Since so much time has passed I am asking for review again so that the commit is not a surprise to anyone. The webrev incorporates Joe's suggestions from long ago and now including an expanded (though probably not complete) unit test.
>
> http://cr.openjdk.java.net/~mduigou/7088913/1/webrev/
>
> Mike
>
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-September/007733.html
More information about the core-libs-dev
mailing list