Review request for 7192302 Remove JDBCRowSetImpl dependency on java.beans
Mandy Chung
mandy.chung at oracle.com
Thu Sep 6 17:54:44 UTC 2012
As the comment noted, the connect method was made protected for Rave
requirement but it's not defined in JdbcRowSet and BaseRowSet. It's a
method specific to the RI and changing it to private is okay if they get
an JdbcRowSet instance by calling the rowset factory. Alan's question
prompts me to look if anyone references JdbcRowSetImpl directly - I find
that the javax.sql.rowset.JdbcRowSet spec has the example to instantiate
JdbcRowSetImpl. Is it still a supported or recommended way? If so,
there is a potential compatibility risk; otherwise, it'd be good to
update the spec to remove reference to JdbcRowSetImpl.
Mandy
On 9/6/2012 10:21 AM, Alan Bateman wrote:
> Lance,
>
> I see you've just pushed this but one thing I didn't spot initially is
> that in the second webrev you changed the protected connect method to
> be private. Is this a supported API and could this cause problems for
> JDBC drivers that extend this?
>
> -Alan
More information about the core-libs-dev
mailing list