Please Review : Javadoc - docencoding not available to stylesheet post 7006270

[jayashree viswanathan]

Hi all ,

Looking for a reviewer for a change request  . This change is in Javadoc 
tool , which doesn't seems to take up value of the docencoding getting 
passed unlike the other generated HTML files .

webrev is available at http://cr.openjdk.java.net/~luchsh/7006270/

Recreation steps and rest of the details at the bottom of the mail thread.

Thanks Jonathan for helping .

Thanks and Regards,
Jayashree Viswanathan


On 11-09-2012 12:49 PM, Jonathan Lu wrote:
> Hello Jayashree,
>
> The patch looks good to me. but I saw some extra tab characters from 
> your patch, could you please reformat it according to the code 
> convention from following link? it will help others to better 
> understand it.
>
> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html 
>
>
> Thanks,
> Jonathan
>
> On 09/04/2012 02:59 PM, jayashree viswanathan wrote:
>> Hi,
>>
>> Please let me know if any one is interested in having a look at this 
>> patch .
>>
>> Thanks and Regards,
>> Jayashree V
>>
>> On 31-08-2012 3:20 PM, jayashree viswanathan wrote:
>>> *Problem statement : *Stylesheet.css is not getting encoded like the 
>>> other generated html files while using -docencoding
>>>
>>> *Recreation step : *
>>> javadoc -docencoding "use non-ascii encoding" HelloWorld.java
>>> say ,
>>> jdk1.8.0\bin\javadoc.exe -docencoding Cp930 -d docencoding3 
>>> HelloWorld.java
>>>
>>> *Explanation :*
>>> The stylesheet.css is not getting generated in the proper encoding 
>>> as in the code the configuration.docencoding is not getting passed 
>>> to the output stream .
>>> while this scenario works in JDK 6 [as confirmed in Java 6u14] , 
>>> below changeset seems to have regressed this when adding new 
>>> copyFile method.
>>>
>>> Changeset:
>>> 792 (ffbf2b2a8611) 7006270: Several javadoc regression tests are 
>>> failing on windows
>>>
>>> Please find the webrev patch with changes and jtreg test .
>>>
>>> http://cr.openjdk.java.net/~luchsh/ojdk-660/
>>>
>>> Thanks and Regards,
>>> Jayashree V
>>>
>>
>