Review Request 8007035: Deprecate SecurityManager.checkMemberAccess
Alan Bateman
Alan.Bateman at oracle.com
Tue Apr 2 12:59:23 UTC 2013
On 29/03/2013 02:55, Mandy Chung wrote:
> Sean, John, Joe,
>
> Can you review this fix todeprecatesthe
> |SecurityManager.checkMemberAccess|
> method as proposed in http://openjdk.java.net/jeps/176?
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8007035/webrev.00
>
I went through the webrev except for the MethodHandles update and it
mostly looks good to me. I agree that checkMemberAccess should be
deprecated.
In the @deprecated comment then it should probably say that it will be
changed in the future to check AllPermission. It would be inconsistent
to throw SecurityException for the fully trusted case.
A minor comment checkMemberAccess L2064-2065 where it might be nicer as:
if (while != Member.PUBLIC && ccl != ...).
-Alan.
More information about the core-libs-dev
mailing list