hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

[Peter Levart]

On 04/03/2013 04:59 PM, Mandy Chung wrote:
> On 4/3/2013 7:01 AM, Alan Bateman wrote:
>> On 03/04/2013 14:29, Peter Levart wrote:
>>> :
>>>
>>> The change was designed to be largely source-level compatible, but 
>>> not binary-level. Is this JavaFX 8? Is it going to be re-compiled 
>>> with recent JDK8? Is JavaFX 8 supposed to be compatible with both 
>>> JDK7 and JDK8 ?
>>>
>>> If PlatformLogger API is supposed to be binary-compatible with 
>>> non-JDK code, then we must revert this change and apply the 
>>> binary-compatible one that uses switch statement.
>>>
>> I don't know what their expectation is but as the builds aren't 
>> integrated then I would expect at least some mix 'n match. Mandy 
>> might have more context. I think (but I'm not certain) that FX has 
>> been using the PlatformLogger for performance/startup reasons but I'm 
>> not certain if there is an "agreement" to provide both source and 
>> binary compatibility going forward.
>
> It depends on whether JavaFX 8 needs to run on older JDK.  I believe 
> not and I'll follow up with the FX team about this and update you.
>
> Alan - thanks for finding this out and filing the bug (8011380)

Another question is whether currently released JavaFX (2.2.7) or any 
older version is already using PlatformLogger and what if someone wants 
to just upgrade to JDK8 and keep using older JavaFX...

Regards, Peter

> Thanks
> Mandy
>