JDK-8011653: Upgrade to JAXP 1.5
Alan Bateman
Alan.Bateman at oracle.com
Mon Apr 8 12:24:03 UTC 2013
On 08/04/2013 08:39, huizhe wang wrote:
> Hi Lance, Alan,
>
> As I mentioned, I'd like to propose an integration of JAXP 1.5 into
> JDK8. JAXP 1.5 adds a new feature to control connections.
>
> Here's the webrev:
> http://cr.openjdk.java.net/~joehw/jdk8/8011653/webrev/
>
> Thanks,
> Joe
I've done a first pass over the spec/javadoc changes (not the
implementation yet).
Are you planning to add @since to each of the new constants in XMLConstants?
For the new properties then it specifies that a "a runtime exception"
will be thrown. Can this be more specific?
The URI scheme is specified in terms of the obsolete RFC 2396 whereas I
think it just needs to be a String that is equal (ignoring case) to the
protocol of the connection that is attempting.
For jaxp.properties then it reads "and property XXX is specified". I'd
probably change this to "the property".
For the existing FEATURE_SECURE_PROCESSING then "accordance with the
letter" is a bit unusual, I would be "the letter" could be dropped.
For each of the factories then it specifies that all implementation are
required to support the new property but this would seem to invalidate
all existing provider implementations. I don't think providers are
versioned so all I can suggest is that this be worded to make it clear
that all implementations that implement JAXP 1.5 or newer support this
property.
A small comment is that there seems to have been previous attempts to
keep some of the files at 80 or thereabouts columns. The new javadoc
requires a bit of horizontal scrolling.
-Alan.
More information about the core-libs-dev
mailing list