RFR 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries (including invokedynamic)

Mike Duigou mike.duigou at oracle.com
Thu Apr 11 04:32:31 UTC 2013


- License on test is the wrong one. Tests don't have classpath exemption.

- The initial block comment with @test doesn't have the normal leading * on each line.

- The commented out part mentioning testWrite should just be removed along with unreferenced code.

Looks otherwise fine to me.

Mike

On Apr 10 2013, at 21:24 , Robert Field wrote:

> Currently blocking lambda library pushes.  Internal class reader used by rmic does not support new constant pool constant types:
> 
> CONSTANT_METHODHANDLE         = 15;
> 
> CONSTANT_METHODTYPE           = 16;
> 
> CONSTANT_INVOKEDYNAMIC        = 18;
> 
> 
> Please review the fix for CR:
> 
>     http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011805
> 
> Webrev:
> 
>     http://cr.openjdk.java.net/~rfield/8011805/




More information about the core-libs-dev mailing list