RFR-8008118

[Chris Hegarty]

On 04/11/2013 05:00 PM, Martin Buchholz wrote:
> Agreed.  When I worked on this, I was only looking at the more difficult
> one.  The NULL check for errmsg should be merged back in.

John,

If you merge back in this small change, then I can sponsor the change 
into jdk8/tl/jdk for you.

Please also provide the 'Reviewed-by' & 'Contributed-by' values for the 
changeset. It is not obvious ;-) You could probably take this offline, 
and then just mail the 'hg export'.

-Chris.

>
>
> On Thu, Apr 11, 2013 at 6:28 AM, Chris Hegarty <chris.hegarty at oracle.com
> <mailto:chris.hegarty at oracle.com>> wrote:
>
>     On 04/11/2013 02:14 PM, Alan Bateman wrote:
>
>         On 10/04/2013 19:14, Martin Buchholz wrote:
>
>             I am happy with the latest webrev - ship it!  Thanks, John!
>
>
>         I agree, new version is so much better.
>
>         Chris - are you sponsoring this one?
>
>         -Alan.
>
>
>
>     In the quite lengthly discussion for this issue we seem to have
>     missed a small change from the original review,
>
>          /* ASCII Decimal representation uses 2.4 times as many bits as
>     binary. */
>           errmsg = NEW(char, strlen(format) + strlen(detail) + 3 *
>     sizeof(errnum));
>     +    if (errmsg == NULL)
>     +        return;
>     +
>
>     -Chris.
>
>