RFR: 8004518 & 8010122 : Default methods on Map

Ulf Zibis Ulf.Zibis at CoSoCo.de
Thu Apr 11 22:15:12 UTC 2013


Am 11.04.2013 22:03, schrieb Mike Duigou:
> Another revision incorporating primarily documentation feedback.
>
> http://cr.openjdk.java.net/~mduigou/JDK-8010122/2/webrev/

There is still a yoda style in ConcurrentMap line 72, HashMap line 361

To be in line with old habits, please remove space after casts. See also: 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6939278

Collections:
lines 1442... + 3900... , indentation for follow up line should be 8

Map:
lines 599..600 bad indentation

Use consistent formatted code examples in javadoc. I like the style from lines 567 to 570, but e.g. from line 622 to 626:
- 2 spaces before <pre>
- indentation should be 4
- line break before }</pre>

-Ulf





More information about the core-libs-dev mailing list