RFR: 8010279 - Comparators should throw NPE on null argument

Henry Jen henry.jen at oracle.com
Fri Apr 12 18:57:49 UTC 2013


On 04/12/2013 11:56 AM, Henry Jen wrote:
> On 04/10/2013 11:09 AM, Alan Bateman wrote:
>> On 10/04/2013 19:00, Henry Jen wrote:
>>> Hi,
>>>
>>> The bug is reported on lambda repo, part of the fix involved code
>>> already integrated into TL/master, thus need help on review and commit.
>>>
>>> Webrev at: http://cr.openjdk.java.net/~henryjen/tl/8010279.0/webrev/
>>>
>>> Simple changes in the code, with a little restructure of jtreg test to
>>> fit convention.
>>>
>>> Cheers,
>>> Henry
>> Looks okay to me.
>>
>> Rather than adding T8010279.java then you could just add to the existing
>> unit test with a testNulls if you want.
>>
> 
> 
> Test moved to testNulls and add a couple more test on nulls for other
> methods.
> 

Forgot the link of updated webrev,

http://cr.openjdk.java.net/~henryjen/tl/8010279.1/webrev/

Cheers,
Henry




More information about the core-libs-dev mailing list