JDK-8011653: Upgrade to JAXP 1.5
Alan Bateman
Alan.Bateman at oracle.com
Mon Apr 15 09:22:05 UTC 2013
On 15/04/2013 08:48, Joe Wang wrote:
> :
>
>>
>> For the new properties then it specifies that a "a runtime exception"
>> will be thrown. Can this be more specific?
>
> They can't be in XMLConstants, but they are in the specific Factories.
> The properties may be supported by factories that may throw different
> exceptions.
I think it would be help if this were expanded to something like "a
runtime exception that is specific to the context is thrown" and give an
example so that it's clear what it saying.
>
> Webrevs updated:
> http://cr.openjdk.java.net/~joehw/jdk8/8011653/webrev/
This looks much better. For now, I've stayed focused on the javadoc/spec
for now as we have to get that right.
The wording "\"jar\" plus the scheme portion" suggests it matches "jar"
exactly and maybe this could be clearer because this is also case
insensitive.
@since on the new properties 1.7. I don't know if this should have 1.8
or JAXP 1.5.
The intending of the <ul> and <li> looks a bit odd when the paragraphs
aren't indented. This doesn't impact the generated javadoc of course,
just looks odd in the source code.
Otherwise I think the javadoc looks okay to me.
-Alan
More information about the core-libs-dev
mailing list